Audit Process
Process for Security Audits
- Choose a file or system to audit (from the
stariumxcv.dev
repository). - Review the code locally to make sure that everything is up to snuff.
- Make changes (if necessary) to enhance the security of the code. If possible, commit these changes to
stariumxcv.dev
. - Create a new branch in
stariumxcv.prod
for the security audit (be sure togit checkout dev
andgit pull
first). A good naming convention for the branch would besecurity-{file or system name}
. - Commit the file (
git add path/to/newfile
git commit -m "security audit for {file/system name}"
) and push it up to Github (git push
). - Go to https://github.com/gwythdarianllc/stariumxcv/pulls
- Click the
New Pull Request
button. - In the first dropdown, choose
base: dev
. - In the second dropdown, choose
compare: security-{file or system name}
. - Assuming a (relatively) short amount of time has passed between when you started work on the new branch and the time you are opening the pull request, you should receive a message that says
Able to merge.
- If this is not the case, try running
git merge dev
. - At this point, you will likely have to resolve any merge conflicts that exist between your current branch and the
dev
branch. If you aren't sure what to do, ask David for help.
- If this is not the case, try running
- If you are able to merge, go ahead and click
Create pull request
. - In the comment section that appears, provide a short description of the what was audited, what was changed (if anything), and confirmation that everything now looks good.
- On the right side, add the following options:
- Reviewers
- Choose two of the following people: davidmwhynot, trainort, or alan-saari.
- Labels
- Apply the label
security-audit
, as well as another other labels that you think would be relevant to the changes made during your work on this branch.
- Apply the label
- Reviewers
- Click
Create Pull Request
.
Review Process
TODO